strongswan.git
2 years agopki: Load pubkey plugin to print public keys
Tobias Brunner [Thu, 15 Jun 2017 12:36:40 +0000 (14:36 +0200)]
pki: Load pubkey plugin to print public keys

Since 3317d0e77b1a the public keys are printed via certificate printer,
but that only works if the public key is actually wrapped, which
requires the pubkey plugin.

Fixes: 3317d0e77b1a ("Standardized printing of certificate information")

2 years agopki: Fix typo in --print man page
Tobias Brunner [Thu, 15 Jun 2017 12:36:19 +0000 (14:36 +0200)]
pki: Fix typo in --print man page

2 years agosql: Use qualified names in SQL query statements
Tobias Brunner [Mon, 12 Jun 2017 07:58:31 +0000 (09:58 +0200)]
sql: Use qualified names in SQL query statements

VIRTUAL is a new reserved keyword in MySQL 5.7.6 that caused some of these
queries to fail.

Fixes #2359.

2 years agostroke: Don't load configs with invalid proposals
Tobias Brunner [Tue, 30 May 2017 16:27:20 +0000 (18:27 +0200)]
stroke: Don't load configs with invalid proposals

References #2347.

2 years agoikev1: Determine transform ID before mapping integrity algorithm ID
Tobias Brunner [Tue, 30 May 2017 16:23:12 +0000 (18:23 +0200)]
ikev1: Determine transform ID before mapping integrity algorithm ID

Due to the lookup based on the mapped algorithm ID the resulting AH
proposals were invalid.

Fixes #2347.

Fixes: 8456d6f5a8e9 ("ikev1: Don't require AH mapping for integrity algorithm when generating proposal")

2 years agoeap-aka-3gpp: Add plugin that implements 3GPP MILENAGE algorithm in software
Tobias Brunner [Tue, 16 May 2017 15:34:02 +0000 (17:34 +0200)]
eap-aka-3gpp: Add plugin that implements 3GPP MILENAGE algorithm in software

This is similar to the eap-aka-3gpp2 plugin. K (optionally concatenated
with OPc) may be configured as binary EAP secret in ipsec.secrets or
swanctl.conf.

Based on a patch by Thomas Strangert.

Fixes #2326.

2 years agoutils: Make second argument to memxor() const
Tobias Brunner [Tue, 16 May 2017 15:30:38 +0000 (17:30 +0200)]
utils: Make second argument to memxor() const

2 years agoandroid: New release after fixing issues with older Android versions and DB upgrade
Tobias Brunner [Tue, 4 Jul 2017 09:52:34 +0000 (11:52 +0200)]
android: New release after fixing issues with older Android versions and DB upgrade

2 years agoandroid: Fix database update from older versions
Tobias Brunner [Tue, 4 Jul 2017 09:44:47 +0000 (11:44 +0200)]
android: Fix database update from older versions

2 years agoandroid: Fix version string on older Android releases
Tobias Brunner [Tue, 4 Jul 2017 09:10:45 +0000 (11:10 +0200)]
android: Fix version string on older Android releases

SECURITY_PATCH is apparently only available since Android 6.

2 years agoandroid: New release after fixing crash with existing profiles
Tobias Brunner [Mon, 3 Jul 2017 11:44:49 +0000 (13:44 +0200)]
android: New release after fixing crash with existing profiles

2 years agoandroid: Fix null pointer dereference with existing profiles
Tobias Brunner [Mon, 3 Jul 2017 11:43:53 +0000 (13:43 +0200)]
android: Fix null pointer dereference with existing profiles

2 years agoandroid: Only show disconnect button if actually connected
Tobias Brunner [Mon, 3 Jul 2017 10:08:57 +0000 (12:08 +0200)]
android: Only show disconnect button if actually connected

2 years agoandroid: New release after adding lots of new stuff
Tobias Brunner [Mon, 3 Jul 2017 08:47:43 +0000 (10:47 +0200)]
android: New release after adding lots of new stuff

2 years agoMerge branch '2309-android-disconnect-button'
Tobias Brunner [Mon, 3 Jul 2017 08:39:33 +0000 (10:39 +0200)]
Merge branch '2309-android-disconnect-button'

Adds a disconnect button to the permanent notification.

Fixes #2309.

2 years agoandroid: Close activity when dialog is canceled if it was not visible before
Tobias Brunner [Fri, 30 Jun 2017 07:46:56 +0000 (09:46 +0200)]
android: Close activity when dialog is canceled if it was not visible before

onPause/onResume() won't work because onPause() is called right before
onNewIntent().

2 years agoandroid: Allow disconnecting via MainActivity but display a confirmation dialog
Tobias Brunner [Fri, 23 Jun 2017 08:35:08 +0000 (10:35 +0200)]
android: Allow disconnecting via MainActivity but display a confirmation dialog

2 years agoandroid: Add disconnect button to notification
Tobias Brunner [Tue, 13 Jun 2017 14:21:50 +0000 (16:21 +0200)]
android: Add disconnect button to notification

2 years agoMerge branch 'android-certreq'
Tobias Brunner [Mon, 3 Jul 2017 08:37:21 +0000 (10:37 +0200)]
Merge branch 'android-certreq'

This adds an option that allows disabling certificate requests during
IKE_AUTH.

2 years agoandroid: Make sending certificate requests configurable in the GUI
Tobias Brunner [Thu, 29 Jun 2017 12:52:28 +0000 (14:52 +0200)]
android: Make sending certificate requests configurable in the GUI

2 years agoandroid: Import the flag to suppress certificate requests
Tobias Brunner [Thu, 29 Jun 2017 11:00:19 +0000 (13:00 +0200)]
android: Import the flag to suppress certificate requests

2 years agoandroid: Add flag to suppress sending certificate requests
Tobias Brunner [Thu, 29 Jun 2017 10:58:58 +0000 (12:58 +0200)]
android: Add flag to suppress sending certificate requests

2 years agoandroid: Add property for simple flags
Tobias Brunner [Thu, 29 Jun 2017 10:58:16 +0000 (12:58 +0200)]
android: Add property for simple flags

2 years agoMerge branch '2365-android-nat-keepalive'
Tobias Brunner [Mon, 3 Jul 2017 08:33:52 +0000 (10:33 +0200)]
Merge branch '2365-android-nat-keepalive'

This makes the NAT-T keepalive interval configurable per connection.

Fixes #2365.

2 years agoandroid: Import NAT-T keepalive interval
Tobias Brunner [Thu, 29 Jun 2017 10:57:07 +0000 (12:57 +0200)]
android: Import NAT-T keepalive interval

2 years agoandroid: Make NAT-T keepalive interval configurable in the GUI
Tobias Brunner [Wed, 28 Jun 2017 16:44:45 +0000 (18:44 +0200)]
android: Make NAT-T keepalive interval configurable in the GUI

2 years agoandroid: Use configured NAT-T keepalive interval
Tobias Brunner [Wed, 28 Jun 2017 16:34:40 +0000 (18:34 +0200)]
android: Use configured NAT-T keepalive interval

2 years agoandroid: Add property for NAT-T keepalive interval
Tobias Brunner [Wed, 28 Jun 2017 16:28:31 +0000 (18:28 +0200)]
android: Add property for NAT-T keepalive interval

2 years agoMerge branch 'android-updates'
Tobias Brunner [Mon, 3 Jul 2017 08:32:35 +0000 (10:32 +0200)]
Merge branch 'android-updates'

This adds support for configuring split-tunneling and per-app VPN, adds
a simple HTTP/S fetcher and enables the revocation plugin, makes the log
view more efficient, imports profiles via SAF and changes multiple other
things.

2 years agoandroid: Use arrays as primary config option for subnets in profile files
Tobias Brunner [Wed, 28 Jun 2017 12:28:38 +0000 (14:28 +0200)]
android: Use arrays as primary config option for subnets in profile files

2 years agoandroid: Change format of address ranges and print sets
Tobias Brunner [Wed, 28 Jun 2017 10:33:17 +0000 (12:33 +0200)]
android: Change format of address ranges and print sets

2 years agoandroid: Make app handling and selection of apps configurable in profile editor
Tobias Brunner [Tue, 27 Jun 2017 13:17:43 +0000 (15:17 +0200)]
android: Make app handling and selection of apps configurable in profile editor

2 years agoandroid: Add simple activity for the selection of apps
Tobias Brunner [Tue, 27 Jun 2017 13:13:30 +0000 (15:13 +0200)]
android: Add simple activity for the selection of apps

2 years agoandroid: Add list fragment for the selection of apps
Tobias Brunner [Tue, 27 Jun 2017 13:10:41 +0000 (15:10 +0200)]
android: Add list fragment for the selection of apps

2 years agoandroid: Add filterable adapter for list of installed/selected apps
Tobias Brunner [Tue, 27 Jun 2017 12:11:16 +0000 (14:11 +0200)]
android: Add filterable adapter for list of installed/selected apps

2 years agoandroid: Add list item layout for installed/selected apps
Tobias Brunner [Tue, 27 Jun 2017 11:54:32 +0000 (13:54 +0200)]
android: Add list item layout for installed/selected apps

2 years agoandroid: Add class that wraps ApplicationInfo for selected apps
Tobias Brunner [Tue, 27 Jun 2017 11:50:18 +0000 (13:50 +0200)]
android: Add class that wraps ApplicationInfo for selected apps

2 years agoandroid: Handle checked state in activated background
Tobias Brunner [Tue, 27 Jun 2017 08:14:43 +0000 (10:14 +0200)]
android: Handle checked state in activated background

2 years agoandroid: Add text color for checkable list entries
Tobias Brunner [Tue, 27 Jun 2017 08:13:54 +0000 (10:13 +0200)]
android: Add text color for checkable list entries

2 years agoandroid: Add a linear layout that is checkable
Tobias Brunner [Tue, 27 Jun 2017 08:12:35 +0000 (10:12 +0200)]
android: Add a linear layout that is checkable

2 years agoandroid: Add convenience methods to get/set selected apps to/from a sorted set
Tobias Brunner [Mon, 26 Jun 2017 14:19:08 +0000 (16:19 +0200)]
android: Add convenience methods to get/set selected apps to/from a sorted set

2 years agoandroid: Import selected/excluded apps from profile file
Tobias Brunner [Mon, 26 Jun 2017 10:38:31 +0000 (12:38 +0200)]
android: Import selected/excluded apps from profile file

2 years agoandroid: Apply selected apps according to config
Tobias Brunner [Mon, 26 Jun 2017 10:02:11 +0000 (12:02 +0200)]
android: Apply selected apps according to config

Either only the selected apps are able to access the VPN or they are
excluded from access to the VPN.

2 years agoandroid: Add property for selected apps to VPN profiles
Tobias Brunner [Mon, 26 Jun 2017 09:35:46 +0000 (11:35 +0200)]
android: Add property for selected apps to VPN profiles

A second property will control if only the selected apps have access to
the VPN or if the selected apps are excluded from the VPN, or if the
functionality is disabled.

2 years agoandroid: Make custom subnets configurable in the GUI
Tobias Brunner [Thu, 22 Jun 2017 10:26:19 +0000 (12:26 +0200)]
android: Make custom subnets configurable in the GUI

2 years agoandroid: Import custom subnets from profile file
Tobias Brunner [Thu, 22 Jun 2017 10:01:42 +0000 (12:01 +0200)]
android: Import custom subnets from profile file

2 years agoandroid: Use configured included subnets instead of negotiated TS
Tobias Brunner [Thu, 22 Jun 2017 09:56:31 +0000 (11:56 +0200)]
android: Use configured included subnets instead of negotiated TS

2 years agoandroid: Add ability to add a range set to another
Tobias Brunner [Thu, 22 Jun 2017 09:23:25 +0000 (11:23 +0200)]
android: Add ability to add a range set to another

2 years agoandroid: Add property for included subnets to VPN profiles
Tobias Brunner [Thu, 22 Jun 2017 09:15:17 +0000 (11:15 +0200)]
android: Add property for included subnets to VPN profiles

2 years agoandroid: Make excluded subnets configurable in the GUI
Tobias Brunner [Wed, 21 Jun 2017 16:29:48 +0000 (18:29 +0200)]
android: Make excluded subnets configurable in the GUI

2 years agoandroid: Import excluded subnets from profile file
Tobias Brunner [Wed, 21 Jun 2017 16:23:33 +0000 (18:23 +0200)]
android: Import excluded subnets from profile file

2 years agoandroid: Exclude configured subnets from the VPN
Tobias Brunner [Wed, 21 Jun 2017 15:21:30 +0000 (17:21 +0200)]
android: Exclude configured subnets from the VPN

2 years agoandroid: Implement Iterable interface and addAll() for range set
Tobias Brunner [Wed, 21 Jun 2017 14:59:40 +0000 (16:59 +0200)]
android: Implement Iterable interface and addAll() for range set

2 years agoandroid: Add ability to remove a range set from another
Tobias Brunner [Wed, 21 Jun 2017 14:22:11 +0000 (16:22 +0200)]
android: Add ability to remove a range set from another

2 years agoandroid: Parse two addresses separated by - as range
Tobias Brunner [Wed, 21 Jun 2017 13:53:39 +0000 (15:53 +0200)]
android: Parse two addresses separated by - as range

2 years agoandroid: Add property for excluded subnets to VPN profiles
Tobias Brunner [Wed, 21 Jun 2017 13:20:58 +0000 (15:20 +0200)]
android: Add property for excluded subnets to VPN profiles

2 years agoandroid: Add class to manage a set of IP address ranges/subnets
Tobias Brunner [Wed, 21 Jun 2017 12:35:06 +0000 (14:35 +0200)]
android: Add class to manage a set of IP address ranges/subnets

2 years agoandroid: Add class to handle IP ranges and subnets
Tobias Brunner [Tue, 13 Jun 2017 16:41:36 +0000 (18:41 +0200)]
android: Add class to handle IP ranges and subnets

2 years agoandroid: Log some information about the Android version and the device
Tobias Brunner [Thu, 15 Jun 2017 17:01:33 +0000 (19:01 +0200)]
android: Log some information about the Android version and the device

2 years agoandroid: Escape backslashes in settings values
Tobias Brunner [Tue, 13 Jun 2017 15:42:33 +0000 (17:42 +0200)]
android: Escape backslashes in settings values

For usernames that use domain specifiers.

2 years agoandroid: Use a specific action to disconnect from the VPN
Tobias Brunner [Thu, 20 Apr 2017 07:33:41 +0000 (09:33 +0200)]
android: Use a specific action to disconnect from the VPN

2 years agoandroid: Try to load existing user cert when importing VPN profile
Tobias Brunner [Tue, 13 Jun 2017 13:15:53 +0000 (15:15 +0200)]
android: Try to load existing user cert when importing VPN profile

2 years agoandroid: Enable revocation plugin
Tobias Brunner [Mon, 12 Jun 2017 13:47:31 +0000 (15:47 +0200)]
android: Enable revocation plugin

2 years agoandroid: Add a simple HTTP(S) fetcher for CRLs
Tobias Brunner [Mon, 12 Jun 2017 13:46:41 +0000 (15:46 +0200)]
android: Add a simple HTTP(S) fetcher for CRLs

2 years agoandroid: Use LOCAL_LDLIBS to link libdl
Tobias Brunner [Thu, 4 May 2017 12:00:50 +0000 (14:00 +0200)]
android: Use LOCAL_LDLIBS to link libdl

Newer NDKs fail otherwise as there is no actual module anymore.

2 years agoandroid: Make log view more efficient
Tobias Brunner [Fri, 21 Apr 2017 12:30:16 +0000 (14:30 +0200)]
android: Make log view more efficient

This bunches several log messages together before posting Runnables.

Fixes #2148.

2 years agoandroid: Don't update state fragment if not attached to an Activity
Tobias Brunner [Fri, 21 Apr 2017 11:59:04 +0000 (13:59 +0200)]
android: Don't update state fragment if not attached to an Activity

When the bound state service finally connects we might not actually be
attached to an Activity.

2 years agoandroid: Make sure every listener at the VPN state service is only registered once
Tobias Brunner [Fri, 21 Apr 2017 11:54:51 +0000 (13:54 +0200)]
android: Make sure every listener at the VPN state service is only registered once

We register when the service connects but also in onStart() (as we
unregister in onStop() to avoid updates when not shown).  So this could
theoretically cause the listener to get registered twice if the service
is connected before onStart() is called (it seems it usually isn't).

2 years agoandroid: Add menu item to import VPN profile via Storage Access Framework
Tobias Brunner [Tue, 18 Apr 2017 15:07:57 +0000 (17:07 +0200)]
android: Add menu item to import VPN profile via Storage Access Framework

This is useful in case the proper MIME type was not set for a downloaded
profile.

2 years agoandroid: Add translation for Traditional Chinese
Tobias Brunner [Tue, 18 Apr 2017 14:14:45 +0000 (16:14 +0200)]
android: Add translation for Traditional Chinese

Courtesy of Chris Chiang.

2 years agoandroid: Move Simplified Chinese translation to values-zg-rCN folder
Tobias Brunner [Tue, 18 Apr 2017 14:07:55 +0000 (16:07 +0200)]
android: Move Simplified Chinese translation to values-zg-rCN folder

2 years agoandroid: Update Gradle plugin and wrapper
Tobias Brunner [Tue, 18 Apr 2017 14:05:00 +0000 (16:05 +0200)]
android: Update Gradle plugin and wrapper

2 years agoconfigure: Install charon-systemd.conf
Tobias Brunner [Thu, 29 Jun 2017 06:36:50 +0000 (08:36 +0200)]
configure: Install charon-systemd.conf

Fixes #2370.

2 years agoikev1: Only delete redundant CHILD_SAs if configured
Tobias Brunner [Tue, 20 Jun 2017 10:50:36 +0000 (12:50 +0200)]
ikev1: Only delete redundant CHILD_SAs if configured

If we find a redundant CHILD_SA (the peer probably rekeyed the SA before
us) we might not want to delete the old SA because the peer might still
use it (same applies to old CHILD_SAs after rekeyings).  So only delete
them if configured to do so.

Fixes #2358.

2 years agoconfigure: Enable coverage for all plugins via PLUGIN_CFLAGS
Tobias Brunner [Tue, 20 Jun 2017 11:52:16 +0000 (13:52 +0200)]
configure: Enable coverage for all plugins via PLUGIN_CFLAGS

2 years agoipsec: Remove `starter` as valid command in --help
Tobias Brunner [Tue, 20 Jun 2017 09:52:41 +0000 (11:52 +0200)]
ipsec: Remove `starter` as valid command in --help

`start` is basically the same thing.

Fixes #2362.

2 years agoopenssl: Properly handle flags in key usage extension
Tobias Brunner [Thu, 8 Jun 2017 11:35:47 +0000 (13:35 +0200)]
openssl: Properly handle flags in key usage extension

2 years agocharon-tkm: Return cloned host from tkm_kernel_sad_t::get_dst_host()
Tobias Brunner [Wed, 7 Jun 2017 13:46:26 +0000 (15:46 +0200)]
charon-tkm: Return cloned host from tkm_kernel_sad_t::get_dst_host()

When an expire is triggered while rekeying, the CHILD_SA might be deleted
while the returned host is still used to queue a rekey job for the CHILD_SA.

2 years agoconfigure: Use pkg-config to determine Ruby CFLAGS/LIBS
Tobias Brunner [Wed, 7 Jun 2017 14:22:11 +0000 (16:22 +0200)]
configure: Use pkg-config to determine Ruby CFLAGS/LIBS

2 years agonm: Version bump to 1.4.2
Tobias Brunner [Tue, 30 May 2017 12:36:17 +0000 (14:36 +0200)]
nm: Version bump to 1.4.2

2 years agoVersion bump to 5.5.3 5.5.3
Andreas Steffen [Mon, 29 May 2017 10:02:48 +0000 (12:02 +0200)]
Version bump to 5.5.3

2 years agoNEWS: Add info about CVE-2017-9022/23
Tobias Brunner [Fri, 26 May 2017 16:05:48 +0000 (18:05 +0200)]
NEWS: Add info about CVE-2017-9022/23

2 years agox509: nameConstraints sequence does not require a loop
Andreas Steffen [Fri, 5 May 2017 09:21:12 +0000 (11:21 +0200)]
x509: nameConstraints sequence does not require a loop

Fixes: CVE-2017-9023

2 years agounit-tests: Updated asn1-parser tests
Andreas Steffen [Fri, 5 May 2017 18:57:28 +0000 (20:57 +0200)]
unit-tests: Updated asn1-parser tests

2 years agoasn1-parser: Fix CHOICE parsing
Andreas Steffen [Fri, 5 May 2017 07:01:08 +0000 (09:01 +0200)]
asn1-parser: Fix CHOICE parsing

Fixes: CVE-2017-9023

2 years agogmp: Make sure the modulus is odd and the exponent not zero
Tobias Brunner [Wed, 29 Mar 2017 09:26:24 +0000 (11:26 +0200)]
gmp: Make sure the modulus is odd and the exponent not zero

Unlike mpz_powm() its secure replacement mpz_powm_sec() has the additional
requirement that the exponent must be > 0 and the modulus has to be odd.
Otherwise, it will crash with a floating-point exception.

Fixes: CVE-2017-9022
Fixes: 3e35a6e7a1b0 ("Use side-channel secured mpz_powm_sec of libgmp 5, if available")

2 years agoimv-swid: Fixed memory leak in http REST interface
Andreas Steffen [Mon, 29 May 2017 07:59:20 +0000 (09:59 +0200)]
imv-swid:  Fixed memory leak in http REST interface

2 years agoleak-detective: Whitelisted memory leaks in FHH IMCs and IMVs
Andreas Steffen [Sun, 28 May 2017 18:07:20 +0000 (20:07 +0200)]
leak-detective: Whitelisted memory leaks in FHH IMCs and IMVs

2 years agoimv-test: Fixed memory leak in server retry use case
Andreas Steffen [Sun, 28 May 2017 18:05:52 +0000 (20:05 +0200)]
imv-test: Fixed memory leak in server retry use case

2 years agolibtnccs: Fixed memory leak of global variables in libxml2
Andreas Steffen [Sun, 28 May 2017 11:51:28 +0000 (13:51 +0200)]
libtnccs: Fixed memory leak of global variables in libxml2

2 years agoike-cfg: Fix memory leak when matching against ranges
Tobias Brunner [Mon, 29 May 2017 08:49:57 +0000 (10:49 +0200)]
ike-cfg: Fix memory leak when matching against ranges

traffic_selector_t::to_subnet() always sets the net/host (unless the
address family was invalid).

Fixes: 3070697f9f7c ("ike: support multiple addresses, ranges and subnets in IKE address config")

2 years agoNEWS: Added some news
Tobias Brunner [Fri, 26 May 2017 16:33:12 +0000 (18:33 +0200)]
NEWS: Added some news

2 years agoike: Apply retransmission_limit before applying the jitter
Tobias Brunner [Fri, 26 May 2017 16:16:40 +0000 (18:16 +0200)]
ike: Apply retransmission_limit before applying the jitter

2 years agoeap-sim-file: Remove redundant enumerator allocation
Tobias Brunner [Fri, 26 May 2017 14:42:59 +0000 (16:42 +0200)]
eap-sim-file: Remove redundant enumerator allocation

2 years agosql: Remove redundant enumerator allocation
Tobias Brunner [Fri, 26 May 2017 13:10:04 +0000 (15:10 +0200)]
sql: Remove redundant enumerator allocation

Interestingly, this doesn't show up in the regression tests because the
compiler removes the first assignment (and thus the allocation) due to
-O2 that's included in our default CFLAGS.

2 years agotesting: Add wrapper around service command
Tobias Brunner [Fri, 26 May 2017 14:24:35 +0000 (16:24 +0200)]
testing: Add wrapper around service command

When charon is started via service command LEAK_DETECTIVE_LOG is not set
because the command strips the environment.  Since we only want the
variable to be set during the automated test runs we can't just set it
in /etc/default/charon.  Instead, we do so in this wrapper when charon is
started and remove the variable again when it is stopped.

2 years agoFixed some typos, courtesy of codespell
Tobias Brunner [Fri, 26 May 2017 12:44:06 +0000 (14:44 +0200)]
Fixed some typos, courtesy of codespell

2 years agoapidoc: Add legacy README so links get properly resolved
Tobias Brunner [Wed, 24 May 2017 12:49:23 +0000 (14:49 +0200)]
apidoc: Add legacy README so links get properly resolved

Also reorders the input files so the READMEs are listed first in the
navigation menu on the left.

2 years agotesting: Added swanctl/rw-eap-md5-id-rsa scenario
Andreas Steffen [Fri, 19 May 2017 19:15:25 +0000 (21:15 +0200)]
testing: Added swanctl/rw-eap-md5-id-rsa scenario

2 years agoREADME: Converted to swanctl configuration scheme
Andreas Steffen [Thu, 11 May 2017 20:22:23 +0000 (22:22 +0200)]
README: Converted to swanctl configuration scheme