strongswan.git
8 years agoDon't use chunk_skip() in asn1_length().
Tobias Brunner [Fri, 11 May 2012 14:05:55 +0000 (16:05 +0200)]
Don't use chunk_skip() in asn1_length().

chunk_skip() returns chunk_empty if the length of the chunk is equal to
the number of bytes to skip, this is problematic as asn1_length() modifies
the original chunk.  asn1_parser_t for instance uses the modified chunk to
later calculate the length of the resulting ASN.1 object which produces
incorrect results if it is based on chunk_empty.

8 years agoChanged memory management and call logic in PKCS#7 parser/generator.
Tobias Brunner [Sat, 12 May 2012 16:15:50 +0000 (18:15 +0200)]
Changed memory management and call logic in PKCS#7 parser/generator.

8 years agoChanged memory management and attribute handling in PKCS#9 wrapper.
Tobias Brunner [Fri, 11 May 2012 15:28:03 +0000 (17:28 +0200)]
Changed memory management and attribute handling in PKCS#9 wrapper.

8 years agoscepclient: Also number CA certificates in case there is more than one.
Tobias Brunner [Fri, 11 May 2012 07:47:56 +0000 (09:47 +0200)]
scepclient: Also number CA certificates in case there is more than one.

Also, only number them if there are multiple certificates.

8 years agoscepclient: Store received RA certificates, using CA cert name as base.
Tobias Brunner [Thu, 10 May 2012 16:16:08 +0000 (18:16 +0200)]
scepclient: Store received RA certificates, using CA cert name as base.

8 years agoscepclient: Use pkcs7_t and pkcs9_t, remove all dependencies to pluto/libfreeswan.
Tobias Brunner [Fri, 11 May 2012 18:31:19 +0000 (20:31 +0200)]
scepclient: Use pkcs7_t and pkcs9_t, remove all dependencies to pluto/libfreeswan.

8 years agoAdded get_attributes() method to pkcs7_t.
Tobias Brunner [Fri, 4 May 2012 17:29:59 +0000 (19:29 +0200)]
Added get_attributes() method to pkcs7_t.

8 years agoscepclient: Local generation of file names.
Tobias Brunner [Fri, 4 May 2012 17:29:07 +0000 (19:29 +0200)]
scepclient: Local generation of file names.

8 years agoscepclient: Replaced usages of datatot().
Tobias Brunner [Fri, 4 May 2012 17:26:31 +0000 (19:26 +0200)]
scepclient: Replaced usages of datatot().

8 years agoscepclient: Migrated logging to libstrongswan.
Tobias Brunner [Fri, 4 May 2012 13:27:06 +0000 (15:27 +0200)]
scepclient: Migrated logging to libstrongswan.

8 years agoLog group added for applications other than daemons.
Tobias Brunner [Fri, 4 May 2012 13:22:43 +0000 (15:22 +0200)]
Log group added for applications other than daemons.

8 years agoscepclient: Some code cleanup.
Tobias Brunner [Fri, 4 May 2012 12:17:59 +0000 (14:17 +0200)]
scepclient: Some code cleanup.

8 years agoUpdated PKCS#7 parser/generator in libstrongswan.
Tobias Brunner [Fri, 4 May 2012 10:50:21 +0000 (12:50 +0200)]
Updated PKCS#7 parser/generator in libstrongswan.

Added some functionality from pluto's version, updated usage of asn1
and crypto primitives. It does compile but is not really tested yet.

8 years agoadded missing parameter in get_my_addr() and get_other_addr() calls
Andreas Steffen [Sat, 9 Jun 2012 12:06:45 +0000 (14:06 +0200)]
added missing parameter in get_my_addr() and get_other_addr() calls

8 years agoversion bump to 5.0.0rc1
Andreas Steffen [Sat, 9 Jun 2012 12:05:08 +0000 (14:05 +0200)]
version bump to 5.0.0rc1

8 years agoadded ikev1/dynamic scenarios using allow-any
Andreas Steffen [Fri, 8 Jun 2012 20:54:12 +0000 (22:54 +0200)]
added ikev1/dynamic scenarios using allow-any

8 years agoremoved whitespace
Andreas Steffen [Fri, 8 Jun 2012 20:34:49 +0000 (22:34 +0200)]
removed whitespace

8 years agoadded ikev2/dynamic-two-peers scenario
Andreas Steffen [Fri, 8 Jun 2012 19:52:20 +0000 (21:52 +0200)]
added ikev2/dynamic-two-peers scenario

8 years agoadded ikev2/dynamic-responder scenario
Andreas Steffen [Fri, 8 Jun 2012 19:21:28 +0000 (21:21 +0200)]
added ikev2/dynamic-responder scenario

8 years agoadded ikev2/dynamic-initiator scenario
Andreas Steffen [Fri, 8 Jun 2012 14:12:15 +0000 (16:12 +0200)]
added ikev2/dynamic-initiator scenario

8 years agoimplemented the right|leftallowany feature
Andreas Steffen [Fri, 8 Jun 2012 11:01:08 +0000 (13:01 +0200)]
implemented the right|leftallowany feature

8 years agoEnforce uniqueness policy in IKEv1 main and aggressive modes
Martin Willi [Fri, 8 Jun 2012 14:15:22 +0000 (16:15 +0200)]
Enforce uniqueness policy in IKEv1 main and aggressive modes

8 years agostarter: Go back to single threaded mode.
Tobias Brunner [Thu, 7 Jun 2012 10:02:14 +0000 (12:02 +0200)]
starter: Go back to single threaded mode.

Mixing multiple threads and fork(2) wasn't a very good idea it seems.
At least in some environments this caused strange side-effects.

8 years agoDisabled listening for kernel events in starter.
Tobias Brunner [Thu, 7 Jun 2012 10:00:37 +0000 (12:00 +0200)]
Disabled listening for kernel events in starter.

8 years agoTry to rekey without KE exchange if peer returns INVALID_KE_PAYLOAD(NONE)
Martin Willi [Fri, 8 Jun 2012 08:35:02 +0000 (10:35 +0200)]
Try to rekey without KE exchange if peer returns INVALID_KE_PAYLOAD(NONE)

According to RFC5996, implementations should just ignore the KE payload
if they select a non-PFS proposals. Some implementations don't, but
return MODP_NONE in INVALID_KE_PAYLOAD, hence we accept that, too.

8 years agoWhile checking for redundant quick modes, compare traffic selectors
Martin Willi [Fri, 8 Jun 2012 08:18:52 +0000 (10:18 +0200)]
While checking for redundant quick modes, compare traffic selectors

If a configuration is instanced more than once using narrowing,
we should keep all unique quick modes up during rekeying.

8 years agoStore shorter soft lifetime of in- and outbound SAs only
Martin Willi [Tue, 5 Jun 2012 14:16:07 +0000 (16:16 +0200)]
Store shorter soft lifetime of in- and outbound SAs only

8 years agoInitiate quick mode rekeying with narrowed traffic selectors
Martin Willi [Tue, 5 Jun 2012 13:32:28 +0000 (15:32 +0200)]
Initiate quick mode rekeying with narrowed traffic selectors

8 years agoUse traffic selectors passed to quick mode constructor as initiator
Martin Willi [Tue, 5 Jun 2012 13:27:34 +0000 (15:27 +0200)]
Use traffic selectors passed to quick mode constructor as initiator

8 years agoInstead of rekeying, delete a quick mode if we have a fresher instance
Martin Willi [Tue, 5 Jun 2012 13:03:10 +0000 (15:03 +0200)]
Instead of rekeying, delete a quick mode if we have a fresher instance

If both peers initiate quick mode rekeying simultaneously, we end up
with duplicate SAs for a configuration. This can't be avoided, nor do
the standards provide an appropriate solution. Instead of closing one
SA immediately, we keep both. But once rekeying triggers, we don't
refresh the SA with the shorter soft lifetime, but delete it.

8 years agoProperly handle empty RDN values in DN strings.
Tobias Brunner [Thu, 7 Jun 2012 14:50:11 +0000 (16:50 +0200)]
Properly handle empty RDN values in DN strings.

8 years agoProperly install policies with ports in PF_KEY kernel interface.
Tobias Brunner [Thu, 7 Jun 2012 12:36:17 +0000 (14:36 +0200)]
Properly install policies with ports in PF_KEY kernel interface.

8 years agoAs responder, enforce the same configuration while rekeying CHILD_SAs
Martin Willi [Wed, 6 Jun 2012 14:00:58 +0000 (16:00 +0200)]
As responder, enforce the same configuration while rekeying CHILD_SAs

8 years agostarter: Only handle SIGCHLD asynchronously and the rest in pselect(2).
Tobias Brunner [Wed, 6 Jun 2012 12:23:25 +0000 (14:23 +0200)]
starter: Only handle SIGCHLD asynchronously and the rest in pselect(2).

8 years agoShow expiration time of rekeyed CHILD_SAs in statusall
Martin Willi [Tue, 5 Jun 2012 08:29:06 +0000 (10:29 +0200)]
Show expiration time of rekeyed CHILD_SAs in statusall

8 years agostarter: (De-)Initialize logging when forking.
Tobias Brunner [Mon, 4 Jun 2012 10:55:05 +0000 (12:55 +0200)]
starter: (De-)Initialize logging when forking.

8 years agostarter: Close open file descriptors when forking daemons.
Tobias Brunner [Thu, 31 May 2012 14:44:03 +0000 (16:44 +0200)]
starter: Close open file descriptors when forking daemons.

8 years agostarter: Changed signal handling now that starter is multi-threaded.
Tobias Brunner [Thu, 31 May 2012 13:53:47 +0000 (15:53 +0200)]
starter: Changed signal handling now that starter is multi-threaded.

8 years agoMark CHILD_SAs used for trap policies to uninstall them properly.
Tobias Brunner [Mon, 4 Jun 2012 15:43:38 +0000 (17:43 +0200)]
Mark CHILD_SAs used for trap policies to uninstall them properly.

If the installation failed the state is not CHILD_ROUTED which means the
wrong priority is used to uninstall the policies.  This is a problem for
kernel interfaces that keep track of installed policies as now the proper
policy is not found (if the priority is considered).

8 years agoNEWS for 4.6.4 added.
Tobias Brunner [Mon, 28 May 2012 10:44:38 +0000 (12:44 +0200)]
NEWS for 4.6.4 added.

8 years agoFixed return values of several functions (e.g. return FALSE for pointer types).
Tobias Brunner [Mon, 7 May 2012 13:47:00 +0000 (15:47 +0200)]
Fixed return values of several functions (e.g. return FALSE for pointer types).

8 years agoFix boolean return value if an empty RSA signature is detected in gmp plugin
Martin Willi [Mon, 7 May 2012 11:51:46 +0000 (13:51 +0200)]
Fix boolean return value if an empty RSA signature is detected in gmp plugin

Fixes CVE-2012-2388.

8 years agoAvoid queueing more than one retry initiate job.
Tobias Brunner [Fri, 25 May 2012 14:09:31 +0000 (16:09 +0200)]
Avoid queueing more than one retry initiate job.

8 years agoRetry IKE_SA initiation if DNS resolution failed.
Tobias Brunner [Fri, 25 May 2012 13:30:32 +0000 (15:30 +0200)]
Retry IKE_SA initiation if DNS resolution failed.

This is disabled by default and can be enabled with the
charon.retry_initiate_interval option in strongswan.conf.

8 years agoJob added to re-initiate an IKE_SA.
Tobias Brunner [Fri, 25 May 2012 13:24:57 +0000 (15:24 +0200)]
Job added to re-initiate an IKE_SA.

8 years agoadded nonce plugin to gcrypt scenarios
Andreas Steffen [Wed, 30 May 2012 05:21:03 +0000 (07:21 +0200)]
added nonce plugin to gcrypt scenarios

8 years agoupgraded ipv6 scenarios to 5.0.0
Andreas Steffen [Tue, 29 May 2012 21:40:01 +0000 (23:40 +0200)]
upgraded ipv6 scenarios to 5.0.0

8 years agoFix MOBIKE address update if responder address changed.
Tobias Brunner [Wed, 9 May 2012 15:53:34 +0000 (17:53 +0200)]
Fix MOBIKE address update if responder address changed.

Use the source address of the current MOBIKE message as peer address
instead of assuming the address cached on the IKE_SA is still valid.

8 years agoResolve hosts before reauthenticating due to address change.
Tobias Brunner [Wed, 9 May 2012 13:46:17 +0000 (15:46 +0200)]
Resolve hosts before reauthenticating due to address change.

8 years agoDon't queue delete_ike_sa job when setting IKE_DELETING.
Tobias Brunner [Wed, 9 May 2012 13:28:29 +0000 (15:28 +0200)]
Don't queue delete_ike_sa job when setting IKE_DELETING.

This avoids deleting IKE_SAs during reauthentication (without
trying to reestablish them).

8 years agoDuring reauthentication reestablish IKE_SA even if deleting the old one fails.
Tobias Brunner [Wed, 9 May 2012 13:15:43 +0000 (15:15 +0200)]
During reauthentication reestablish IKE_SA even if deleting the old one fails.

8 years agoIntegrated main parts of IKE_REAUTH task into ike_sa_t.reestablish.
Tobias Brunner [Wed, 9 May 2012 13:14:34 +0000 (15:14 +0200)]
Integrated main parts of IKE_REAUTH task into ike_sa_t.reestablish.

8 years agoFixed route lookup in case MOBIKE is not enabled.
Tobias Brunner [Tue, 8 May 2012 14:48:51 +0000 (16:48 +0200)]
Fixed route lookup in case MOBIKE is not enabled.

8 years agoenable xauth-eap plugin in UML scenarios
Andreas Steffen [Fri, 25 May 2012 15:02:39 +0000 (17:02 +0200)]
enable xauth-eap plugin in UML scenarios

8 years agoadded nonce plugin in default host configurations
Andreas Steffen [Fri, 25 May 2012 15:00:03 +0000 (17:00 +0200)]
added nonce plugin in default host configurations

8 years agoupgraded ike scenarios to 5.0.0
Andreas Steffen [Fri, 25 May 2012 14:58:17 +0000 (16:58 +0200)]
upgraded ike scenarios to 5.0.0

8 years agoadded IKEv1 IPCOMP pluto-charon interoperability scenarios
Andreas Steffen [Fri, 25 May 2012 10:52:21 +0000 (12:52 +0200)]
added IKEv1 IPCOMP pluto-charon interoperability scenarios

8 years agoAdded encapsulation mode transform attribute to IPComp proposal.
Tobias Brunner [Fri, 25 May 2012 07:24:49 +0000 (09:24 +0200)]
Added encapsulation mode transform attribute to IPComp proposal.

8 years agoupgraded ikev1/compress to 5.0.0
Andreas Steffen [Thu, 24 May 2012 15:36:27 +0000 (17:36 +0200)]
upgraded ikev1/compress to 5.0.0

8 years agoUpdated ipsec.conf(5) to reflect changes to IPComp support.
Tobias Brunner [Thu, 24 May 2012 13:31:15 +0000 (15:31 +0200)]
Updated ipsec.conf(5) to reflect changes to IPComp support.

8 years agoAdd an additional proposal without IPComp to SA payload.
Tobias Brunner [Thu, 24 May 2012 12:40:12 +0000 (14:40 +0200)]
Add an additional proposal without IPComp to SA payload.

8 years agoAdded log message if peer does not accept/provide IPComp proposal.
Tobias Brunner [Thu, 24 May 2012 12:36:57 +0000 (14:36 +0200)]
Added log message if peer does not accept/provide IPComp proposal.

8 years agoAdded support to negotiate IPComp during Quick Mode.
Tobias Brunner [Thu, 24 May 2012 12:00:44 +0000 (14:00 +0200)]
Added support to negotiate IPComp during Quick Mode.

8 years agoAdded support for IKEv1 IPComp proposals in SA payload.
Tobias Brunner [Thu, 24 May 2012 11:31:53 +0000 (13:31 +0200)]
Added support for IKEv1 IPComp proposals in SA payload.

8 years agoAdded support for IKEv1 IPComp proposals in proposal substructure.
Tobias Brunner [Wed, 23 May 2012 16:44:48 +0000 (18:44 +0200)]
Added support for IKEv1 IPComp proposals in proposal substructure.

8 years agoFix memleak during Quick Mode in case no SPI can be allocated from kernel.
Tobias Brunner [Wed, 23 May 2012 16:09:21 +0000 (18:09 +0200)]
Fix memleak during Quick Mode in case no SPI can be allocated from kernel.

8 years agoProperly filter IKEv1 proposals consisting of multiple proposal payloads.
Tobias Brunner [Wed, 23 May 2012 15:55:41 +0000 (17:55 +0200)]
Properly filter IKEv1 proposals consisting of multiple proposal payloads.

Since a proposal_t object is created for each transform contained in the
proposal payload, it does not work to simply remove the last proposal_t
object added to the list (there may be several other extracted from the
previous proposal payload).

8 years agoFixed check for loaded plugins with feature types that are not compared exactly.
Tobias Brunner [Thu, 24 May 2012 10:58:38 +0000 (12:58 +0200)]
Fixed check for loaded plugins with feature types that are not compared exactly.

Previously e.g. RNGs with weaker strength would have overwritten stronger
ones.

8 years agoget_match() method added to hashtable_t.
Tobias Brunner [Thu, 24 May 2012 10:54:38 +0000 (12:54 +0200)]
get_match() method added to hashtable_t.

8 years agoadded ikev1/xauth-rsa-eap-md5-radius scenario
Andreas Steffen [Thu, 24 May 2012 07:26:00 +0000 (09:26 +0200)]
added ikev1/xauth-rsa-eap-md5-radius scenario

8 years agoUse a hashtable to check for already loaded plugin features.
Tobias Brunner [Wed, 23 May 2012 15:41:11 +0000 (17:41 +0200)]
Use a hashtable to check for already loaded plugin features.

8 years agoHash function for plugin features added.
Tobias Brunner [Wed, 23 May 2012 15:37:53 +0000 (17:37 +0200)]
Hash function for plugin features added.

8 years agoload nonce plugin
Andreas Steffen [Wed, 23 May 2012 13:05:57 +0000 (15:05 +0200)]
load nonce plugin

8 years agoadded ikev1 pluto-charon interoperability scenarios
Andreas Steffen [Wed, 23 May 2012 12:47:41 +0000 (14:47 +0200)]
added ikev1 pluto-charon interoperability scenarios

8 years agoupgraded ikev1 scenarios to 5.0.0
Andreas Steffen [Wed, 23 May 2012 12:45:15 +0000 (14:45 +0200)]
upgraded ikev1 scenarios to 5.0.0

8 years agoApply IDir before deriving keys as aggressive initiator
Martin Willi [Wed, 23 May 2012 10:27:47 +0000 (12:27 +0200)]
Apply IDir before deriving keys as aggressive initiator

8 years agoUse received identity to look up PSK as aggressive responder
Martin Willi [Wed, 23 May 2012 10:18:45 +0000 (12:18 +0200)]
Use received identity to look up PSK as aggressive responder

8 years agoCheck if we actually have an initiating packet to free while processing responses
Martin Willi [Wed, 23 May 2012 09:50:12 +0000 (11:50 +0200)]
Check if we actually have an initiating packet to free while processing responses

8 years agolist IKEv1 Aggressive Mode in ipsec statusall
Andreas Steffen [Wed, 23 May 2012 09:12:27 +0000 (11:12 +0200)]
list IKEv1 Aggressive Mode in ipsec statusall

8 years agoSwitch to alternative peer config in IKEv1 Main and Aggressive Mode.
Tobias Brunner [Mon, 21 May 2012 10:07:17 +0000 (12:07 +0200)]
Switch to alternative peer config in IKEv1 Main and Aggressive Mode.

8 years agoCancel pending retransmits when flushing active task queue
Martin Willi [Mon, 21 May 2012 12:53:40 +0000 (14:53 +0200)]
Cancel pending retransmits when flushing active task queue

8 years agoCancel active quick mode task when receiving INFORMATIONAL error
Martin Willi [Mon, 21 May 2012 12:48:48 +0000 (14:48 +0200)]
Cancel active quick mode task when receiving INFORMATIONAL error

8 years agoFlush task queues explicitly, not implicitly if task returns ALREADY_DONE
Martin Willi [Mon, 21 May 2012 12:17:09 +0000 (14:17 +0200)]
Flush task queues explicitly, not implicitly if task returns ALREADY_DONE

8 years agoWrap task managers flush_queue() in IKE_SA
Martin Willi [Mon, 21 May 2012 12:05:01 +0000 (14:05 +0200)]
Wrap task managers flush_queue() in IKE_SA

8 years agoMake task managers flush_queue() method public
Martin Willi [Mon, 21 May 2012 12:02:35 +0000 (14:02 +0200)]
Make task managers flush_queue() method public

8 years agoDestroy Netlink socket only after deleting remaining source routes.
Tobias Brunner [Mon, 21 May 2012 11:19:57 +0000 (13:19 +0200)]
Destroy Netlink socket only after deleting remaining source routes.

8 years agoEnumerate correct list while removing nonce_gens, fix deregistration
Martin Willi [Mon, 21 May 2012 10:28:01 +0000 (12:28 +0200)]
Enumerate correct list while removing nonce_gens, fix deregistration

8 years agoAdded a convenience function to dump backtraces for gdb-less debugging
Martin Willi [Mon, 21 May 2012 10:18:49 +0000 (12:18 +0200)]
Added a convenience function to dump backtraces for gdb-less debugging

8 years agoFix IKEv1 DPD clear, destroying IKE_SA even if reestablish not needed
Martin Willi [Mon, 21 May 2012 10:17:32 +0000 (12:17 +0200)]
Fix IKEv1 DPD clear, destroying IKE_SA even if reestablish not needed

8 years agoProperly munmap/close file if loading IMC/IMV fails.
Tobias Brunner [Fri, 18 May 2012 10:26:03 +0000 (12:26 +0200)]
Properly munmap/close file if loading IMC/IMV fails.

8 years agoRemove executable flag from source files.
Tobias Brunner [Fri, 18 May 2012 07:52:52 +0000 (09:52 +0200)]
Remove executable flag from source files.

8 years agoUse separate Doxygen groups for IKEv1 and IKEv2 entities (authenticators, tasks etc.).
Tobias Brunner [Fri, 18 May 2012 07:52:15 +0000 (09:52 +0200)]
Use separate Doxygen groups for IKEv1 and IKEv2 entities (authenticators, tasks etc.).

8 years agoRemoved superfluous @param in bus.h.
Tobias Brunner [Fri, 18 May 2012 06:37:32 +0000 (08:37 +0200)]
Removed superfluous @param in bus.h.

8 years agowhitelist: Make sure listed IDs are null-terminated.
Tobias Brunner [Fri, 18 May 2012 07:27:24 +0000 (09:27 +0200)]
whitelist: Make sure listed IDs are null-terminated.

8 years agopkcs8: Initialize salt and IV properly.
Tobias Brunner [Fri, 18 May 2012 06:36:37 +0000 (08:36 +0200)]
pkcs8: Initialize salt and IV properly.

8 years agoList registered nonce generators in statusall output.
Tobias Brunner [Wed, 16 May 2012 16:26:36 +0000 (18:26 +0200)]
List registered nonce generators in statusall output.

8 years agoAdd enumerator for registered nonce generators.
Tobias Brunner [Wed, 16 May 2012 16:25:25 +0000 (18:25 +0200)]
Add enumerator for registered nonce generators.

8 years agoUse nonce_gen instead of rng to generate nonces
Adrian-Ken Rueegsegger [Wed, 2 May 2012 15:49:41 +0000 (17:49 +0200)]
Use nonce_gen instead of rng to generate nonces

Replace usage of rng plugin with nonce generator to create nonces in
IKE_INIT, CHILD_CREATE and QUICK_MODE tasks and the IKEv1 phase 1 helper.

8 years agoAdd create_nonce_gen function to keymat interface
Adrian-Ken Rueegsegger [Wed, 2 May 2012 15:49:35 +0000 (17:49 +0200)]
Add create_nonce_gen function to keymat interface

This function returns a nonce generator object.

8 years agoAdd nonce plugin implementation
Adrian-Ken Rueegsegger [Wed, 2 May 2012 15:49:32 +0000 (17:49 +0200)]
Add nonce plugin implementation

This nonce generator uses an RNG to generate nonces. The RNG quality is
currently set to RNG_WEAK which is the same value used in IKE init.

The plugin is enabled and thus built by default.