constraints: Add permitted/excludedNameConstraints check
authorMartin Willi <martin@revosec.ch>
Tue, 14 Oct 2014 14:29:28 +0000 (16:29 +0200)
committerMartin Willi <martin@revosec.ch>
Thu, 30 Oct 2014 10:40:48 +0000 (11:40 +0100)
src/libstrongswan/tests/Makefile.am
src/libstrongswan/tests/suites/test_certnames.c [new file with mode: 0644]
src/libstrongswan/tests/tests.h

index 1f118cc..2a05dc9 100644 (file)
@@ -41,6 +41,7 @@ tests_SOURCES = tests.h tests.c \
   suites/test_ecdsa.c \
   suites/test_rsa.c \
   suites/test_certpolicy.c \
+  suites/test_certnames.c \
   suites/test_host.c \
   suites/test_hasher.c \
   suites/test_crypter.c \
diff --git a/src/libstrongswan/tests/suites/test_certnames.c b/src/libstrongswan/tests/suites/test_certnames.c
new file mode 100644 (file)
index 0000000..e307028
--- /dev/null
@@ -0,0 +1,398 @@
+/*
+ * Copyright (C) 2014 Martin Willi
+ * Copyright (C) 2014 revosec AG
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.  See <http://www.fsf.org/copyleft/gpl.txt>.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * for more details.
+ */
+
+#include "test_suite.h"
+
+#include <asn1/asn1.h>
+#include <credentials/sets/mem_cred.h>
+#include <credentials/certificates/x509.h>
+
+/**
+ * RSA private key, so we don't have to generate one
+ */
+static char keydata[] = {
+  0x30,0x82,0x02,0x5e,0x02,0x01,0x00,0x02,0x81,0x81,0x00,0xb1,0x9b,0xd4,0x51,0x24,
+  0xfc,0x56,0x1d,0x3d,0xfb,0xa2,0xea,0x37,0x02,0x70,0x72,0x87,0x84,0x2f,0x3b,0x2d,
+  0x6e,0x22,0xef,0x3f,0x37,0x04,0xb2,0x6f,0xb7,0xe7,0xd8,0x58,0x05,0xde,0x34,0xbf,
+  0x99,0xe6,0x40,0x7a,0x56,0xa7,0x73,0xf5,0x98,0xcb,0xb0,0x37,0x90,0x5e,0xd1,0x3f,
+  0xf4,0x73,0x50,0x7f,0x53,0x8e,0xf1,0x04,0x25,0xb4,0x77,0x22,0x4e,0x8a,0x9d,0x27,
+  0x8f,0x6f,0xaf,0x59,0xbd,0xb0,0x0f,0xf0,0xaa,0x11,0x94,0x66,0x16,0x10,0x58,0xad,
+  0x77,0xa1,0xac,0x58,0xb4,0xd0,0x0d,0xbc,0x11,0xe0,0xc0,0xe9,0x29,0xdc,0x42,0x63,
+  0x01,0x23,0x4f,0x28,0x41,0x6d,0x34,0x9e,0x0c,0x4a,0xc8,0x62,0x83,0xb5,0x71,0x71,
+  0x0b,0x51,0xc0,0x4c,0x37,0xd4,0x68,0x19,0x52,0x9a,0x8b,0x02,0x03,0x01,0x00,0x01,
+  0x02,0x81,0x81,0x00,0x82,0xca,0x33,0x16,0xb2,0x3a,0xd4,0x1b,0x62,0x9a,0x9c,0xc5,
+  0x07,0x4f,0x57,0x89,0x2f,0x7c,0x4a,0xdf,0xb4,0x3b,0xc7,0xa4,0x11,0x14,0x2d,0xf4,
+  0x4c,0xca,0xcc,0x03,0x88,0x06,0x82,0x34,0xab,0xe7,0xe4,0x24,0x15,0x33,0x1c,0xcb,
+  0x0a,0xcf,0xc3,0x27,0x78,0x33,0x6b,0x6f,0x82,0x3e,0x3c,0x70,0xc9,0xe2,0xb9,0x7f,
+  0x88,0xc3,0x4f,0x59,0xb5,0x8e,0xa3,0x81,0xd9,0x88,0x1f,0xc0,0x38,0xbc,0xc8,0x93,
+  0x40,0x0f,0x43,0xd8,0x72,0x12,0xb4,0xcc,0x6d,0x76,0x0a,0x6f,0x01,0x05,0xa8,0x88,
+  0xf4,0x57,0x44,0xd2,0x05,0xc4,0x77,0xf5,0xfb,0x1b,0xf3,0xb2,0x0d,0x90,0xb8,0xb4,
+  0x63,0x62,0x70,0x2c,0xe4,0x28,0xd8,0x20,0x10,0x85,0x4a,0x5e,0x63,0xa9,0xb0,0xdd,
+  0xba,0xd0,0x32,0x49,0x02,0x41,0x00,0xdb,0x77,0xf1,0xdd,0x1a,0x12,0xc5,0xfb,0x2b,
+  0x5b,0xb2,0xcd,0xb6,0xd0,0x4c,0xc4,0xe5,0x93,0xd6,0xf8,0x88,0xfc,0x18,0x40,0x21,
+  0x9c,0xf7,0x2d,0x60,0x6f,0x91,0xf5,0x73,0x3c,0xf7,0x7f,0x67,0x1d,0x5b,0xb5,0xee,
+  0x29,0xc1,0xd4,0xc6,0xdb,0x44,0x4c,0x40,0x05,0x63,0xaa,0x71,0x95,0x18,0x14,0xa7,
+  0x23,0x9f,0x7a,0xee,0x7f,0xb5,0xc7,0x02,0x41,0x00,0xcf,0x2c,0x24,0x50,0x65,0xf4,
+  0x94,0x7b,0xe9,0xf3,0x13,0x77,0xea,0x27,0x3c,0x6f,0x03,0x84,0xa7,0x7d,0xa2,0x54,
+  0x40,0x97,0x82,0x0e,0xd9,0x09,0x9f,0x4a,0xa6,0x75,0xe5,0x66,0xe4,0x9c,0x59,0xd9,
+  0x3a,0xe6,0xf7,0xd8,0x8b,0x68,0xb0,0x21,0x52,0x31,0xb3,0x4a,0xa0,0x2c,0x41,0xd7,
+  0x1f,0x7b,0xe2,0x0f,0x15,0xc9,0x6e,0xc0,0xe5,0x1d,0x02,0x41,0x00,0x9c,0x1a,0x61,
+  0x9f,0x89,0xc7,0x26,0xa9,0x33,0xba,0xe2,0xa0,0x6d,0xd3,0x15,0x77,0xcb,0x6f,0xef,
+  0xad,0x12,0x0a,0x75,0xd9,0x4f,0xcf,0x4d,0x05,0x2a,0x9d,0xd1,0x2c,0xcb,0xcd,0xe6,
+  0xa0,0xe9,0x20,0x39,0xb6,0x5a,0xf3,0xba,0x99,0xf4,0xe3,0xcb,0x5d,0x8d,0x00,0x08,
+  0x57,0x18,0xb9,0x1a,0xca,0xbd,0xe3,0x99,0xb1,0x1f,0xe9,0x18,0xcb,0x02,0x40,0x65,
+  0x35,0x1b,0x48,0x6b,0x86,0x60,0x43,0x68,0xb6,0xe6,0xfb,0xdd,0xd7,0xed,0x1e,0x0e,
+  0x89,0xef,0x88,0xe0,0x94,0x68,0x39,0x9b,0xbf,0xc5,0x27,0x7e,0x39,0xe9,0xb8,0x0e,
+  0xa9,0x85,0x65,0x1c,0x3f,0x93,0x16,0xe2,0x5d,0x57,0x3d,0x7d,0x4d,0xc9,0xe9,0x9d,
+  0xbd,0x07,0x22,0x97,0xc7,0x90,0x09,0xe5,0x15,0x99,0x7f,0x1e,0x2b,0xfd,0xc1,0x02,
+  0x41,0x00,0x92,0x78,0xfe,0x04,0xa0,0x53,0xed,0x36,0x97,0xbd,0x16,0xce,0x91,0x9b,
+  0xbe,0x1f,0x8e,0x40,0x00,0x99,0x0c,0x49,0x15,0xca,0x59,0xd3,0xe3,0xd4,0xeb,0x71,
+  0xcf,0xda,0xd7,0xc8,0x99,0x74,0xfc,0x6b,0xe8,0xfd,0xe5,0xe0,0x49,0x61,0xcb,0xda,
+  0xe3,0xe7,0x8b,0x72,0xb5,0x69,0x73,0x2b,0x8b,0x54,0xcb,0xd9,0x48,0x6d,0x61,0x02,
+  0x49,0xe8,
+};
+
+/**
+ * Issue a certificate with permitted/excluded name constraints
+ */
+static certificate_t* create_cert(certificate_t *ca, char *subject, char *san,
+                                                               x509_flag_t flags, identification_t *permitted,
+                                                               identification_t *excluded)
+{
+       private_key_t *privkey;
+       public_key_t *pubkey;
+       certificate_t *cert;
+       identification_t *id;
+       linked_list_t *plist, *elist, *sans;
+
+       privkey = lib->creds->create(lib->creds, CRED_PRIVATE_KEY, KEY_RSA,
+                                                                BUILD_BLOB_ASN1_DER, chunk_from_thing(keydata),
+                                                                BUILD_END);
+       ck_assert(privkey);
+       pubkey = privkey->get_public_key(privkey);
+       ck_assert(pubkey);
+       plist = linked_list_create();
+       if (permitted)
+       {
+               plist->insert_last(plist, permitted);
+       }
+       elist = linked_list_create();
+       if (excluded)
+       {
+               elist->insert_last(elist, excluded);
+       }
+       sans = linked_list_create();
+       if (san)
+       {
+               id = identification_create_from_string(san);
+               sans->insert_last(sans, id);
+       }
+       id = identification_create_from_string(subject);
+       cert = lib->creds->create(lib->creds, CRED_CERTIFICATE, CERT_X509,
+                                               BUILD_SIGNING_KEY, privkey,
+                                               BUILD_PUBLIC_KEY, pubkey,
+                                               BUILD_SUBJECT, id,
+                                               BUILD_X509_FLAG, flags,
+                                               BUILD_SIGNING_CERT, ca,
+                                               BUILD_SUBJECT_ALTNAMES, sans,
+                                               BUILD_PERMITTED_NAME_CONSTRAINTS, plist,
+                                               BUILD_EXCLUDED_NAME_CONSTRAINTS, elist,
+                                               BUILD_END);
+       ck_assert(cert);
+       id->destroy(id);
+       sans->destroy_offset(sans, offsetof(identification_t, destroy));
+       plist->destroy_offset(plist, offsetof(identification_t, destroy));
+       elist->destroy_offset(elist, offsetof(identification_t, destroy));
+       privkey->destroy(privkey);
+       pubkey->destroy(pubkey);
+
+       return cert;
+}
+
+/**
+ * Check if a certificate with given subject has a valid trustchain
+ */
+static bool check_trust(identification_t *subject)
+{
+       enumerator_t *certs;
+       certificate_t *cert;
+       bool trusted;
+
+       certs = lib->credmgr->create_trusted_enumerator(lib->credmgr, KEY_ANY,
+                                                                                                       subject, FALSE);
+       trusted = certs->enumerate(certs, &cert, NULL);
+       certs->destroy(certs);
+
+       return trusted;
+}
+
+static mem_cred_t *creds;
+
+START_SETUP(setup)
+{
+       creds = mem_cred_create();
+       lib->credmgr->add_set(lib->credmgr, &creds->set);
+}
+END_SETUP
+
+START_TEARDOWN(teardown)
+{
+       lib->credmgr->remove_set(lib->credmgr, &creds->set);
+       creds->destroy(creds);
+       lib->credmgr->flush_cache(lib->credmgr, CERT_ANY);
+}
+END_TEARDOWN
+
+static struct {
+       char *constraint;
+       char *subject;
+       bool good;
+} permitted_dn[] = {
+       { "C=CH, O=strongSwan", "C=CH, O=strongSwan, CN=tester", TRUE },
+       { "C=CH, O=strongSwan", "C=CH, O=strong", FALSE },
+       { "C=CH, O=strongSwan", "C=CH, O=strong, CN=tester", FALSE },
+       { "C=CH, O=strongSwan", "C=CH, O=another, CN=tester", FALSE },
+       { "C=CH, O=strongSwan", "C=CH, CN=tester, O=strongSwan", FALSE },
+};
+
+START_TEST(test_permitted_dn)
+{
+       certificate_t *ca, *im, *sj;
+       identification_t *id;
+
+       id = identification_create_from_string(permitted_dn[_i].constraint);
+       ca = create_cert(NULL, "C=CH, O=strongSwan, CN=CA", NULL, X509_CA, id, NULL);
+       id = identification_create_from_string(permitted_dn[_i].constraint);
+       im = create_cert(ca, "C=CH, O=strongSwan, CN=IM", NULL, X509_CA, id, NULL);
+       sj = create_cert(im, permitted_dn[_i].subject, NULL, 0, NULL, NULL);
+
+       creds->add_cert(creds, TRUE, ca);
+       creds->add_cert(creds, FALSE, im);
+       creds->add_cert(creds, FALSE, sj);
+
+       ck_assert(check_trust(sj->get_subject(sj)) == permitted_dn[_i].good);
+}
+END_TEST
+
+static struct {
+       id_type_t ctype;
+       char *cdata;
+       char *subject;
+       bool good;
+} permitted_san[] = {
+       { ID_FQDN, ".strongswan.org", "test.strongswan.org", TRUE },
+       { ID_FQDN, "strongswan.org", "test.strongswan.org", TRUE },
+       { ID_FQDN, "a.b.c.strongswan.org", "d.a.b.c.strongswan.org", TRUE },
+       { ID_FQDN, "a.b.c.strongswan.org", "a.b.c.d.strongswan.org", FALSE },
+       { ID_FQDN, "strongswan.org", "strongswan.org.com", FALSE },
+       { ID_FQDN, ".strongswan.org", "strongswan.org", FALSE },
+       { ID_FQDN, "strongswan.org", "nostrongswan.org", FALSE },
+       { ID_FQDN, "strongswan.org", "swan.org", FALSE },
+       { ID_FQDN, "strongswan.org", "swan.org", FALSE },
+       { ID_RFC822_ADDR, "tester@strongswan.org", "tester@strongswan.org", TRUE },
+       { ID_RFC822_ADDR, "tester@strongswan.org", "atester@strongswan.org", FALSE },
+       { ID_RFC822_ADDR, "strongswan.org", "tester@strongswan.org", TRUE },
+       { ID_RFC822_ADDR, "strongswan.org", "tester@test.strongswan.org", FALSE },
+       { ID_RFC822_ADDR, ".strongswan.org", "tester@test.strongswan.org", TRUE },
+       { ID_RFC822_ADDR, ".strongswan.org", "tester@strongswan.org", FALSE },
+};
+
+START_TEST(test_permitted_san)
+{
+       certificate_t *ca, *sj;
+       identification_t *id;
+
+       id = identification_create_from_encoding(permitted_san[_i].ctype,
+                                                                       chunk_from_str(permitted_san[_i].cdata));
+       ca = create_cert(NULL, "CN=CA", NULL, X509_CA, id, NULL);
+       sj = create_cert(ca, "CN=SJ", permitted_san[_i].subject, 0, NULL, NULL);
+
+       creds->add_cert(creds, TRUE, ca);
+       creds->add_cert(creds, FALSE, sj);
+
+       ck_assert(check_trust(sj->get_subject(sj)) == permitted_san[_i].good);
+}
+END_TEST
+
+static struct {
+       char *constraint;
+       char *subject;
+       bool good;
+} excluded_dn[] = {
+       { "C=CH, O=another", "C=CH, O=strongSwan, CN=tester", TRUE },
+       { "C=CH, O=another", "C=CH, O=anot", TRUE },
+       { "C=CH, O=another", "C=CH, O=anot, CN=tester", TRUE },
+       { "C=CH, O=another", "C=CH, O=another, CN=tester", FALSE },
+       { "C=CH, O=another", "C=CH, CN=tester, O=another", TRUE },
+};
+
+START_TEST(test_excluded_dn)
+{
+       certificate_t *ca, *im, *sj;
+       identification_t *id;
+
+       id = identification_create_from_string(excluded_dn[_i].constraint);
+       ca = create_cert(NULL, "C=CH, O=strongSwan, CN=CA", NULL, X509_CA, NULL, id);
+       id = identification_create_from_string(excluded_dn[_i].constraint);
+       im = create_cert(ca, "C=CH, O=strongSwan, CN=IM", NULL, X509_CA, NULL, id);
+       sj = create_cert(im, excluded_dn[_i].subject, NULL, 0, NULL, NULL);
+
+       creds->add_cert(creds, TRUE, ca);
+       creds->add_cert(creds, FALSE, im);
+       creds->add_cert(creds, FALSE, sj);
+
+       ck_assert(check_trust(sj->get_subject(sj)) == excluded_dn[_i].good);
+}
+END_TEST
+
+static struct {
+       id_type_t ctype;
+       char *cdata;
+       char *subject;
+       bool good;
+} excluded_san[] = {
+       { ID_FQDN, ".strongswan.org", "test.strongswan.org", FALSE },
+       { ID_FQDN, "strongswan.org", "test.strongswan.org", FALSE },
+       { ID_FQDN, "a.b.c.strongswan.org", "d.a.b.c.strongswan.org", FALSE },
+       { ID_FQDN, "a.b.c.strongswan.org", "a.b.c.d.strongswan.org", TRUE },
+       { ID_FQDN, "strongswan.org", "strongswan.org.com", TRUE },
+       { ID_FQDN, ".strongswan.org", "strongswan.org", TRUE },
+       { ID_FQDN, "strongswan.org", "nostrongswan.org", TRUE },
+       { ID_FQDN, "strongswan.org", "swan.org", TRUE },
+       { ID_FQDN, "strongswan.org", "swan.org", TRUE },
+       { ID_RFC822_ADDR, "tester@strongswan.org", "tester@strongswan.org", FALSE },
+       { ID_RFC822_ADDR, "tester@strongswan.org", "atester@strongswan.org", TRUE },
+       { ID_RFC822_ADDR, "strongswan.org", "tester@strongswan.org", FALSE },
+       { ID_RFC822_ADDR, "strongswan.org", "tester@test.strongswan.org", TRUE },
+       { ID_RFC822_ADDR, ".strongswan.org", "tester@test.strongswan.org", FALSE },
+       { ID_RFC822_ADDR, ".strongswan.org", "tester@strongswan.org", TRUE },
+};
+
+START_TEST(test_excluded_san)
+{
+       certificate_t *ca, *sj;
+       identification_t *id;
+
+       id = identification_create_from_encoding(excluded_san[_i].ctype,
+                                                                       chunk_from_str(excluded_san[_i].cdata));
+       ca = create_cert(NULL, "CN=CA", NULL, X509_CA, NULL, id);
+       sj = create_cert(ca, "CN=SJ", excluded_san[_i].subject, 0, NULL, NULL);
+
+       creds->add_cert(creds, TRUE, ca);
+       creds->add_cert(creds, FALSE, sj);
+
+       ck_assert(check_trust(sj->get_subject(sj)) == excluded_san[_i].good);
+}
+END_TEST
+
+static struct {
+       char *caconst;
+       char *imconst;
+       char *subject;
+       bool good;
+} permitted_dninh[] = {
+       { "C=CH", "C=CH, O=strongSwan", "C=CH, O=strongSwan, CN=tester", TRUE },
+       { "C=CH", "C=DE, O=strongSwan", "C=CH, O=strongSwan, CN=tester", FALSE },
+       { "C=CH, O=strongSwan", "C=CH", "C=CH", FALSE },
+};
+
+START_TEST(test_permitted_dninh)
+{
+       certificate_t *ca, *im, *sj;
+       identification_t *id;
+
+       id = identification_create_from_string(permitted_dninh[_i].caconst);
+       ca = create_cert(NULL, "C=CH, O=strongSwan, CN=CA", NULL, X509_CA, id, NULL);
+       id = identification_create_from_string(permitted_dninh[_i].imconst);
+       im = create_cert(ca, "C=CH, O=strongSwan, CN=IM", NULL, X509_CA, id, NULL);
+       sj = create_cert(im, permitted_dninh[_i].subject, NULL, 0, NULL, NULL);
+
+       creds->add_cert(creds, TRUE, ca);
+       creds->add_cert(creds, FALSE, im);
+       creds->add_cert(creds, FALSE, sj);
+
+       ck_assert(check_trust(sj->get_subject(sj)) == permitted_dninh[_i].good);
+}
+END_TEST
+
+static struct {
+       char *caconst;
+       char *imconst;
+       char *subject;
+       bool good;
+} excluded_dninh[] = {
+       { "C=CH, O=strongSwan", "C=CH", "C=DE", TRUE },
+       { "C=CH, O=strongSwan", "C=DE", "C=CH", FALSE },
+       { "C=CH", "C=CH, O=strongSwan", "C=CH, O=strongSwan, CN=tester", FALSE },
+};
+
+START_TEST(test_excluded_dninh)
+{
+       certificate_t *ca, *im, *sj;
+       identification_t *id;
+
+       id = identification_create_from_string(excluded_dninh[_i].caconst);
+       ca = create_cert(NULL, "C=CH, O=strongSwan, CN=CA", NULL, X509_CA, NULL, id);
+       id = identification_create_from_string(excluded_dninh[_i].imconst);
+       im = create_cert(ca, "C=DE, CN=IM", NULL, X509_CA, NULL, id);
+       sj = create_cert(im, excluded_dninh[_i].subject, NULL, 0, NULL, NULL);
+
+       creds->add_cert(creds, TRUE, ca);
+       creds->add_cert(creds, FALSE, im);
+       creds->add_cert(creds, FALSE, sj);
+
+       ck_assert(check_trust(sj->get_subject(sj)) == excluded_dninh[_i].good);
+}
+END_TEST
+
+Suite *certnames_suite_create()
+{
+       Suite *s;
+       TCase *tc;
+
+       s = suite_create("certnames");
+
+       tc = tcase_create("permitted DN name constraints");
+       tcase_add_checked_fixture(tc, setup, teardown);
+       tcase_add_loop_test(tc, test_permitted_dn, 0, countof(permitted_dn));
+       suite_add_tcase(s, tc);
+
+       tc = tcase_create("permitted subjectAltName constraints");
+       tcase_add_checked_fixture(tc, setup, teardown);
+       tcase_add_loop_test(tc, test_permitted_san, 0, countof(permitted_san));
+       suite_add_tcase(s, tc);
+
+       tc = tcase_create("excluded DN constraints");
+       tcase_add_checked_fixture(tc, setup, teardown);
+       tcase_add_loop_test(tc, test_excluded_dn, 0, countof(excluded_dn));
+       suite_add_tcase(s, tc);
+
+       tc = tcase_create("excluded subjectAltName constraints");
+       tcase_add_checked_fixture(tc, setup, teardown);
+       tcase_add_loop_test(tc, test_excluded_san, 0, countof(excluded_san));
+       suite_add_tcase(s, tc);
+
+       tc = tcase_create("permitted DN name constraint inherit");
+       tcase_add_checked_fixture(tc, setup, teardown);
+       tcase_add_loop_test(tc, test_permitted_dninh, 0, countof(permitted_dninh));
+       suite_add_tcase(s, tc);
+
+       tc = tcase_create("excluded DN name constraint inherit");
+       tcase_add_checked_fixture(tc, setup, teardown);
+       tcase_add_loop_test(tc, test_excluded_dninh, 0, countof(excluded_dninh));
+       suite_add_tcase(s, tc);
+
+       return s;
+}
index eff848f..7fe8dbf 100644 (file)
@@ -33,6 +33,7 @@ TEST_SUITE(vectors_suite_create)
 TEST_SUITE_DEPEND(ecdsa_suite_create, PRIVKEY_GEN, KEY_ECDSA)
 TEST_SUITE_DEPEND(rsa_suite_create, PRIVKEY_GEN, KEY_RSA)
 TEST_SUITE_DEPEND(certpolicy_suite_create, CERT_ENCODE, CERT_X509)
+TEST_SUITE_DEPEND(certnames_suite_create, CERT_ENCODE, CERT_X509)
 TEST_SUITE(host_suite_create)
 TEST_SUITE(printf_suite_create)
 TEST_SUITE(hasher_suite_create)