unit-tests: Add tests for IKE rekeying if INVALID_KE_PAYLOAD notifies are received
authorTobias Brunner <tobias@strongswan.org>
Wed, 1 Jun 2016 13:49:45 +0000 (15:49 +0200)
committerTobias Brunner <tobias@strongswan.org>
Fri, 17 Jun 2016 16:48:07 +0000 (18:48 +0200)
src/libcharon/tests/suites/test_ike_rekey.c

index 8cbff27..ba39657 100644 (file)
@@ -103,6 +103,105 @@ START_TEST(test_regular)
 END_TEST
 
 /**
+ * IKE_SA rekeying where the responder does not agree with the DH group selected
+ * by the initiator, either initiated by the original initiator or responder of
+ * the IKE_SA.
+ */
+START_TEST(test_regular_ke_invalid)
+{
+       exchange_test_sa_conf_t conf = {
+               .initiator = {
+                       .ike = "aes128-sha256-modp2048-modp3072",
+               },
+               .responder = {
+                       .ike = "aes128-sha256-modp3072-modp2048",
+               },
+       };
+       ike_sa_t *a, *b, *sa;
+       status_t s;
+
+       lib->settings->set_bool(lib->settings, "%s.prefer_configured_proposals",
+                                                       FALSE, lib->ns);
+       if (_i)
+       {       /* responder rekeys the IKE_SA */
+               exchange_test_helper->establish_sa(exchange_test_helper,
+                                                                                  &b, &a, &conf);
+       }
+       else
+       {       /* initiator rekeys the IKE_SA */
+               exchange_test_helper->establish_sa(exchange_test_helper,
+                                                                                  &a, &b, &conf);
+       }
+       /* these should never get called as this results in a successful rekeying */
+       assert_hook_not_called(ike_updown);
+       assert_hook_not_called(child_updown);
+
+       lib->settings->set_bool(lib->settings, "%s.prefer_configured_proposals",
+                                                       TRUE, lib->ns);
+
+       initiate_rekey(a);
+
+       /* CREATE_CHILD_SA { SA, Ni, KEi } --> */
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_ESTABLISHED);
+       assert_child_sa_count(b, 1);
+       assert_ike_sa_count(0);
+
+       /* <-- CREATE_CHILD_SA { N(INVAL_KE) } */
+       assert_single_notify(IN, INVALID_KE_PAYLOAD);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { SA, Ni, KEi } --> */
+       assert_hook_rekey(ike_rekey, 1, 3);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_REKEYED);
+       assert_child_sa_count(b, 0);
+       sa = assert_ike_sa_checkout(3, 5, FALSE);
+       assert_ike_sa_state(sa, IKE_ESTABLISHED);
+       assert_child_sa_count(sa, 1);
+       assert_ike_sa_count(1);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { SA, Nr, KEr } */
+       assert_hook_rekey(ike_rekey, 1, 3);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_DELETING);
+       assert_child_sa_count(a, 0);
+       sa = assert_ike_sa_checkout(3, 5, TRUE);
+       assert_ike_sa_state(sa, IKE_ESTABLISHED);
+       assert_child_sa_count(sa, 1);
+       assert_ike_sa_count(2);
+       assert_hook();
+
+       /* we don't expect this hook to get called anymore */
+       assert_hook_not_called(ike_rekey);
+
+       /* INFORMATIONAL { D } --> */
+       assert_single_payload(IN, PLV2_DELETE);
+       s = exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       ck_assert_int_eq(DESTROY_ME, s);
+       call_ikesa(b, destroy);
+       /* <-- INFORMATIONAL { } */
+       assert_message_empty(IN);
+       s = exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       ck_assert_int_eq(DESTROY_ME, s);
+       call_ikesa(a, destroy);
+
+       /* ike_rekey/ike_updown/child_updown */
+       assert_hook();
+       assert_hook();
+       assert_hook();
+
+       charon->ike_sa_manager->flush(charon->ike_sa_manager);
+}
+END_TEST
+
+/**
  * Both peers initiate the IKE_SA rekeying concurrently and should handle the
  * collision properly depending on the nonces.
  */
@@ -258,6 +357,374 @@ START_TEST(test_collision)
 END_TEST
 
 /**
+ * Both peers initiate the IKE_SA rekeying concurrently but the proposed DH
+ * gropus are not the same.  After handling the INVALID_KE_PAYLOAD they should
+ * still handle the collision properly depending on the nonces.
+ */
+START_TEST(test_collision_ke_invalid)
+{
+       exchange_test_sa_conf_t conf = {
+               .initiator = {
+                       .ike = "aes128-sha256-modp2048-modp3072",
+               },
+               .responder = {
+                       .ike = "aes128-sha256-modp3072-modp2048",
+               },
+       };
+       ike_sa_t *a, *b, *sa;
+       status_t status;
+
+       lib->settings->set_bool(lib->settings, "%s.prefer_configured_proposals",
+                                                       FALSE, lib->ns);
+
+       exchange_test_helper->establish_sa(exchange_test_helper,
+                                                                          &a, &b, &conf);
+
+       lib->settings->set_bool(lib->settings, "%s.prefer_configured_proposals",
+                                                       TRUE, lib->ns);
+
+       /* Six nonces and SPIs are needed (SPI 1 and 2 are used for the initial
+        * IKE_SA):
+        *     N1/3 -----\    /----- N2/4
+        *                \--/-----> N3/5
+        *     N4/6 <-------/  /---- INVAL_KE
+        * INVAL_KE -----\    /
+        *          <-----\--/
+        *     N1/3 -----\ \------->
+        *                \    /---- N2/4
+        *                 \--/----> N5/7
+        *     N6/8 <--------/ /---- ...
+        *      ... ------\
+        * We test this four times, each time a different nonce is the lowest.
+        */
+       struct {
+               /* Nonces used at each point */
+               u_char nonces[4];
+               /* SPIs of the deleted IKE_SAs (either redundant or replaced) */
+               uint32_t del_a_i, del_a_r;
+               uint32_t del_b_i, del_b_r;
+               /* SPIs of the kept IKE_SA */
+               uint32_t spi_i, spi_r;
+       } data[] = {
+               { { 0x00, 0xFF, 0xFF, 0xFF }, 3, 7, 1, 2, 4, 8 },
+               { { 0xFF, 0x00, 0xFF, 0xFF }, 1, 2, 4, 8, 3, 7 },
+               { { 0xFF, 0xFF, 0x00, 0xFF }, 3, 7, 1, 2, 4, 8 },
+               { { 0xFF, 0xFF, 0xFF, 0x00 }, 1, 2, 4, 8, 3, 7 },
+       };
+       /* these should never get called as this results in a successful rekeying */
+       assert_hook_not_called(ike_updown);
+       assert_hook_not_called(child_updown);
+
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[0];
+       initiate_rekey(a);
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[1];
+       initiate_rekey(b);
+
+       /* CREATE_CHILD_SA { SA, Ni, KEi } --> */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[2];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_REKEYING);
+       assert_child_sa_count(b, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { SA, Ni, KEi } */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[3];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { N(INVAL_KE) } */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[0];
+       assert_hook_not_called(ike_rekey);
+       assert_single_notify(IN, INVALID_KE_PAYLOAD);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { N(INVAL_KE) } --> */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[1];
+       assert_hook_not_called(child_rekey);
+       assert_single_notify(IN, INVALID_KE_PAYLOAD);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_REKEYING);
+       assert_child_sa_count(b, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { SA, Ni, KEi } --> */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[2];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_REKEYING);
+       assert_child_sa_count(b, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { SA, Ni, KEi } */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[3];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* simplify next steps by checking in original IKE_SAs */
+       charon->ike_sa_manager->checkin(charon->ike_sa_manager, a);
+       charon->ike_sa_manager->checkin(charon->ike_sa_manager, b);
+       assert_ike_sa_count(2);
+
+       /* <-- CREATE_CHILD_SA { SA, Nr, KEr } */
+       assert_hook_rekey(ike_rekey, 1, data[_i].spi_i);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       /* as original initiator a is initiator of both SAs it could delete */
+       sa = assert_ike_sa_checkout(data[_i].del_a_i, data[_i].del_a_r, TRUE);
+       assert_ike_sa_state(sa, IKE_DELETING);
+       assert_child_sa_count(sa, 0);
+       /* if b won it will delete the original SA a initiated */
+       sa = assert_ike_sa_checkout(data[_i].del_b_i, data[_i].del_b_r,
+                                                               data[_i].del_b_i == 1);
+       assert_ike_sa_state(sa, IKE_REKEYED);
+       assert_child_sa_count(sa, 0);
+       sa = assert_ike_sa_checkout(data[_i].spi_i, data[_i].spi_r,
+                                                               data[_i].del_a_i == 1);
+       assert_ike_sa_state(sa, IKE_ESTABLISHED);
+       assert_child_sa_count(sa, 1);
+       assert_ike_sa_count(4);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { SA, Nr, KEr } --> */
+       assert_hook_rekey(ike_rekey, 1, data[_i].spi_i);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       /* if b wins it deletes the SA originally initiated by a */
+       sa = assert_ike_sa_checkout(data[_i].del_b_i, data[_i].del_b_r,
+                                                               data[_i].del_b_i != 1);
+       assert_ike_sa_state(sa, IKE_DELETING);
+       assert_child_sa_count(sa, 0);
+       /* a only deletes SAs for which b is responder */
+       sa = assert_ike_sa_checkout(data[_i].del_a_i, data[_i].del_a_r, FALSE);
+       assert_ike_sa_state(sa, IKE_REKEYED);
+       assert_child_sa_count(sa, 0);
+       sa = assert_ike_sa_checkout(data[_i].spi_i, data[_i].spi_r,
+                                                               data[_i].del_b_i == 1);
+       assert_ike_sa_state(sa, IKE_ESTABLISHED);
+       assert_child_sa_count(sa, 1);
+       assert_ike_sa_count(6);
+       assert_hook();
+
+       /* we don't expect this hook to get called anymore */
+       assert_hook_not_called(ike_rekey);
+
+       /* INFORMATIONAL { D } --> */
+       assert_single_payload(IN, PLV2_DELETE);
+       sa = assert_ike_sa_checkout(data[_i].del_a_i, data[_i].del_a_r, FALSE);
+       status = exchange_test_helper->process_message(exchange_test_helper, sa,
+                                                                                                  NULL);
+       ck_assert_int_eq(DESTROY_ME, status);
+       charon->ike_sa_manager->checkin_and_destroy(charon->ike_sa_manager, sa);
+       assert_ike_sa_count(5);
+       /* <-- INFORMATIONAL { D } */
+       assert_single_payload(IN, PLV2_DELETE);
+       sa = assert_ike_sa_checkout(data[_i].del_b_i, data[_i].del_b_r,
+                                                               data[_i].del_b_i == 1);
+       status = exchange_test_helper->process_message(exchange_test_helper, sa,
+                                                                                                  NULL);
+       ck_assert_int_eq(DESTROY_ME, status);
+       charon->ike_sa_manager->checkin_and_destroy(charon->ike_sa_manager, sa);
+       assert_ike_sa_count(4);
+       /* <-- INFORMATIONAL { } */
+       assert_message_empty(IN);
+       sa = assert_ike_sa_checkout(data[_i].del_a_i, data[_i].del_a_r, TRUE);
+       status = exchange_test_helper->process_message(exchange_test_helper, sa,
+                                                                                                  NULL);
+       ck_assert_int_eq(DESTROY_ME, status);
+       charon->ike_sa_manager->checkin_and_destroy(charon->ike_sa_manager, sa);
+       assert_ike_sa_count(3);
+       /* INFORMATIONAL { } --> */
+       assert_message_empty(IN);
+       sa = assert_ike_sa_checkout(data[_i].del_b_i, data[_i].del_b_r,
+                                                               data[_i].del_b_i != 1);
+       status = exchange_test_helper->process_message(exchange_test_helper, sa,
+                                                                                                  NULL);
+       ck_assert_int_eq(DESTROY_ME, status);
+       charon->ike_sa_manager->checkin_and_destroy(charon->ike_sa_manager, sa);
+       assert_ike_sa_count(2);
+
+       /* ike_rekey/ike_updown/child_updown */
+       assert_hook();
+       assert_hook();
+       assert_hook();
+
+       charon->ike_sa_manager->flush(charon->ike_sa_manager);
+}
+END_TEST
+
+/**
+ * This is like the collision above but one of the retries is delayed.
+ */
+START_TEST(test_collision_ke_invalid_delayed_retry)
+{
+       exchange_test_sa_conf_t conf = {
+               .initiator = {
+                       .ike = "aes128-sha256-modp2048-modp3072",
+               },
+               .responder = {
+                       .ike = "aes128-sha256-modp3072-modp2048",
+               },
+       };
+       ike_sa_t *a, *b, *sa;
+       message_t *msg;
+       status_t s;
+
+       lib->settings->set_bool(lib->settings, "%s.prefer_configured_proposals",
+                                                       FALSE, lib->ns);
+
+       exchange_test_helper->establish_sa(exchange_test_helper,
+                                                                          &a, &b, &conf);
+
+       lib->settings->set_bool(lib->settings, "%s.prefer_configured_proposals",
+                                                       TRUE, lib->ns);
+
+       /* Five nonces and SPIs are needed (SPI 1 and 2 are used for the initial
+        * IKE_SA):
+        *     N1/3 -----\    /----- N2/4
+        *                \--/-----> N3/5
+        *     N4/6 <-------/  /---- INVAL_KE
+        * INVAL_KE -----\    /
+        *          <-----\--/
+        *     N1/3 -----\ \------->
+        *          <-----\--------- N2/4
+        *     N5/7 -------\------->
+        *          <-------\------- DELETE
+        *      ... ------\  \----->
+        *                     /---- TEMP_FAIL
+        *
+        * We test this three times, each time a different nonce is the lowest.
+        */
+       struct {
+               /* Nonces used at each point */
+               u_char nonces[3];
+       } data[] = {
+               { { 0x00, 0xFF, 0xFF } },
+               { { 0xFF, 0x00, 0xFF } },
+               { { 0xFF, 0xFF, 0x00 } },
+       };
+       /* these should never get called as this results in a successful rekeying */
+       assert_hook_not_called(ike_updown);
+       assert_hook_not_called(child_updown);
+
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[0];
+       initiate_rekey(a);
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[1];
+       initiate_rekey(b);
+
+       /* CREATE_CHILD_SA { SA, Ni, KEi } --> */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[2];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_REKEYING);
+       assert_child_sa_count(b, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { SA, Ni, KEi } */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[0];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { N(INVAL_KE) } */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[0];
+       assert_hook_not_called(ike_rekey);
+       assert_single_notify(IN, INVALID_KE_PAYLOAD);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { N(INVAL_KE) } --> */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[1];
+       assert_hook_not_called(child_rekey);
+       assert_single_notify(IN, INVALID_KE_PAYLOAD);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_REKEYING);
+       assert_child_sa_count(b, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* delay the CREATE_CHILD_SA request from a to b */
+       msg = exchange_test_helper->sender->dequeue(exchange_test_helper->sender);
+
+       /* <-- CREATE_CHILD_SA { SA, Ni, KEi } */
+       exchange_test_helper->nonce_first_byte = data[_i].nonces[2];
+       assert_hook_not_called(ike_rekey);
+       exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       assert_ike_sa_state(a, IKE_REKEYING);
+       assert_child_sa_count(a, 1);
+       assert_ike_sa_count(0);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { SA, Nr, KEr } --> */
+       assert_hook_rekey(ike_rekey, 1, 4);
+       exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       assert_ike_sa_state(b, IKE_DELETING);
+       assert_child_sa_count(b, 0);
+       sa = assert_ike_sa_checkout(4, 7, TRUE);
+       assert_ike_sa_state(sa, IKE_ESTABLISHED);
+       assert_child_sa_count(sa, 1);
+       assert_ike_sa_count(1);
+       assert_hook();
+
+       /* CREATE_CHILD_SA { SA, Ni, KEi } --> (delayed) */
+       assert_single_notify(OUT, TEMPORARY_FAILURE);
+       exchange_test_helper->process_message(exchange_test_helper, b, msg);
+       assert_ike_sa_state(b, IKE_DELETING);
+
+       /* <-- INFORMATIONAL { D } */
+       assert_hook_rekey(ike_rekey, 1, 4);
+       assert_single_payload(IN, PLV2_DELETE);
+       s = exchange_test_helper->process_message(exchange_test_helper, a, NULL);
+       ck_assert_int_eq(DESTROY_ME, s);
+       call_ikesa(a, destroy);
+       sa = assert_ike_sa_checkout(4, 7, FALSE);
+       assert_ike_sa_state(sa, IKE_ESTABLISHED);
+       assert_child_sa_count(sa, 1);
+       assert_ike_sa_count(2);
+       assert_hook();
+
+       /* <-- CREATE_CHILD_SA { N(TEMP_FAIL) } */
+       /* the SA is already gone */
+       msg = exchange_test_helper->sender->dequeue(exchange_test_helper->sender);
+       msg->destroy(msg);
+
+       /* INFORMATIONAL { } --> */
+       assert_hook_not_called(ike_rekey);
+       assert_message_empty(IN);
+       s = exchange_test_helper->process_message(exchange_test_helper, b, NULL);
+       ck_assert_int_eq(DESTROY_ME, s);
+       call_ikesa(b, destroy);
+       assert_hook();
+
+       /* ike_updown/child_updown */
+       assert_hook();
+       assert_hook();
+
+       charon->ike_sa_manager->flush(charon->ike_sa_manager);
+}
+END_TEST
+
+/**
  * This is like the rekey collision above, but one peer deletes the
  * redundant/old SA before the other peer receives the CREATE_CHILD_SA
  * response:
@@ -991,10 +1458,13 @@ Suite *ike_rekey_suite_create()
 
        tc = tcase_create("regular");
        tcase_add_loop_test(tc, test_regular, 0, 2);
+       tcase_add_loop_test(tc, test_regular_ke_invalid, 0, 2);
        suite_add_tcase(s, tc);
 
        tc = tcase_create("collisions rekey");
        tcase_add_loop_test(tc, test_collision, 0, 4);
+       tcase_add_loop_test(tc, test_collision_ke_invalid, 0, 4);
+       tcase_add_loop_test(tc, test_collision_ke_invalid_delayed_retry, 0, 3);
        tcase_add_loop_test(tc, test_collision_delayed_response, 0, 4);
        tcase_add_loop_test(tc, test_collision_dropped_request, 0, 3);
        tcase_add_loop_test(tc, test_collision_delayed_request, 0, 3);