starter: Avoid hiding global variable when checking PID file
authorTobias Brunner <tobias@strongswan.org>
Tue, 28 Jan 2020 10:30:23 +0000 (11:30 +0100)
committerTobias Brunner <tobias@strongswan.org>
Tue, 28 Jan 2020 14:29:40 +0000 (15:29 +0100)
src/starter/starter.c

index 506fe47..8263661 100644 (file)
@@ -255,14 +255,14 @@ static void fatal_signal_handler(int signal)
        abort();
 }
 
-static bool check_pid(char *pid_file)
+static bool check_pid(char *file)
 {
        struct stat stb;
        FILE *pidfile;
 
-       if (stat(pid_file, &stb) == 0)
+       if (stat(file, &stb) == 0)
        {
-               pidfile = fopen(pid_file, "r");
+               pidfile = fopen(file, "r");
                if (pidfile)
                {
                        char buf[64];
@@ -279,8 +279,8 @@ static bool check_pid(char *pid_file)
                                return TRUE;
                        }
                }
-               DBG1(DBG_APP, "removing pidfile '%s', process not running", pid_file);
-               unlink(pid_file);
+               DBG1(DBG_APP, "removing pidfile '%s', process not running", file);
+               unlink(file);
        }
        return FALSE;
 }