libipsec: Remove unused reqid parameter from ipsec_sa_mgr_t.get_spi()
authorMartin Willi <martin@revosec.ch>
Wed, 15 Oct 2014 15:19:56 +0000 (17:19 +0200)
committerMartin Willi <martin@revosec.ch>
Thu, 19 Feb 2015 14:42:22 +0000 (15:42 +0100)
src/frontends/android/jni/libandroidbridge/kernel/android_ipsec.c
src/libcharon/plugins/kernel_libipsec/kernel_libipsec_ipsec.c
src/libipsec/ipsec_sa_mgr.c
src/libipsec/ipsec_sa_mgr.h

index 24640a0..84b3b60 100644 (file)
@@ -50,7 +50,7 @@ METHOD(kernel_ipsec_t, get_spi, status_t,
        private_kernel_android_ipsec_t *this, host_t *src, host_t *dst,
        u_int8_t protocol, u_int32_t reqid, u_int32_t *spi)
 {
-       return ipsec->sas->get_spi(ipsec->sas, src, dst, protocol, reqid, spi);
+       return ipsec->sas->get_spi(ipsec->sas, src, dst, protocol, spi);
 }
 
 METHOD(kernel_ipsec_t, get_cpi, status_t,
index bd07a67..5ab0c97 100644 (file)
@@ -238,7 +238,7 @@ METHOD(kernel_ipsec_t, get_spi, status_t,
        private_kernel_libipsec_ipsec_t *this, host_t *src, host_t *dst,
        u_int8_t protocol, u_int32_t reqid, u_int32_t *spi)
 {
-       return ipsec->sas->get_spi(ipsec->sas, src, dst, protocol, reqid, spi);
+       return ipsec->sas->get_spi(ipsec->sas, src, dst, protocol, spi);
 }
 
 METHOD(kernel_ipsec_t, get_cpi, status_t,
index 1db1776..d1850b0 100644 (file)
@@ -396,12 +396,10 @@ static bool allocate_spi(private_ipsec_sa_mgr_t *this, u_int32_t spi)
 
 METHOD(ipsec_sa_mgr_t, get_spi, status_t,
        private_ipsec_sa_mgr_t *this, host_t *src, host_t *dst, u_int8_t protocol,
-       u_int32_t reqid, u_int32_t *spi)
+       u_int32_t *spi)
 {
        u_int32_t spi_new;
 
-       DBG2(DBG_ESP, "allocating SPI for reqid {%u}", reqid);
-
        this->mutex->lock(this->mutex);
        if (!this->rng)
        {
@@ -420,7 +418,7 @@ METHOD(ipsec_sa_mgr_t, get_spi, status_t,
                                                                 (u_int8_t*)&spi_new))
                {
                        this->mutex->unlock(this->mutex);
-                       DBG1(DBG_ESP, "failed to allocate SPI for reqid {%u}", reqid);
+                       DBG1(DBG_ESP, "failed to allocate SPI");
                        return FAILED;
                }
                /* make sure the SPI is valid (not in range 0-255) */
@@ -432,7 +430,7 @@ METHOD(ipsec_sa_mgr_t, get_spi, status_t,
 
        *spi = spi_new;
 
-       DBG2(DBG_ESP, "allocated SPI %.8x for reqid {%u}", ntohl(*spi), reqid);
+       DBG2(DBG_ESP, "allocated SPI %.8x", ntohl(*spi));
        return SUCCESS;
 }
 
index 8c234ce..3e6efaa 100644 (file)
@@ -45,12 +45,11 @@ struct ipsec_sa_mgr_t {
         * @param src                   source address of the SA
         * @param dst                   destination address of the SA
         * @param protocol              protocol of the SA (only ESP supported)
-        * @param reqid                 reqid for the SA
         * @param spi                   the allocated SPI
         * @return                              SUCCESS of operation successful
         */
        status_t (*get_spi)(ipsec_sa_mgr_t *this, host_t *src, host_t *dst,
-                                               u_int8_t protocol, u_int32_t reqid, u_int32_t *spi);
+                                               u_int8_t protocol, u_int32_t *spi);
 
        /**
         * Add a new SA